Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect JUnit logger against implementations without usesDataProvider() #3446

Merged
merged 1 commit into from Dec 11, 2018
Merged

Protect JUnit logger against implementations without usesDataProvider() #3446

merged 1 commit into from Dec 11, 2018

Conversation

epdenouden
Copy link
Contributor

Fixes #3441

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #3446 into 7.5 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                7.5    #3446      +/-   ##
============================================
+ Coverage     83.41%   83.42%   +<.01%     
- Complexity     3618     3619       +1     
============================================
  Files           143      143              
  Lines          9632     9635       +3     
============================================
+ Hits           8035     8038       +3     
  Misses         1597     1597
Impacted Files Coverage Δ Complexity Δ
src/Util/Log/JUnit.php 94.44% <100%> (+0.11%) 35 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a7421...4271be7. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 9cd210a into sebastianbergmann:7.5 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants