Make ExceptionMessage constraint strict, expectedException can handle only expected class, not message nor code #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use full expectedExceptionMessage one
Codecov Report
@@ Coverage Diff @@
## 6.5 #3326 +/- ##
============================================
- Coverage 80.14% 80.12% -0.02%
+ Complexity 2854 2851 -3
============================================
Files 105 105
Lines 7529 7523 -6
============================================
- Hits 6034 6028 -6
Misses 1495 1495
Continue to review full report at Codecov.
|
|
Can you please send a pull request for |
|
Thank you 👍 |
|
sure, here it is #3343 |
|
For the record: this was merged but then reverted in branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3325
Commit logs are meaningful.
As described in ticket, this change may be consider a little bigger than it appears on first look.
Eg, changing
strposto===in constraint makes (by purpose) partial message not working anymore, and@expectedException \ClassOfException Message Codeannotation, well, make no sense anymore - asMessagecan be exactly one, single word - and without partial exception, it's pointless...