Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect TestDox output for data provider with indexed array #3321

Closed
wants to merge 2 commits into from
Closed

Incorrect TestDox output for data provider with indexed array #3321

wants to merge 2 commits into from

Conversation

kubawerlos
Copy link
Contributor

Extending test case would produce the failure:

--- Expected
+++ Actual
@@ @@
  ✔ Does something with data set "two"
  ✔ Does something else with data set "one"
  ✔ Does something else with data set "two"
- ✔ With provider with indexed array with data set #0
- ✔ With provider with indexed array with data set #1
+ ✔ With provider with indexed array with data set ""
+ ✔ With provider with indexed array with data set ""
  ✔ ... true ...
  ✔ ... 1 ...
  ✔ ... 1.0 ...

@kubawerlos kubawerlos changed the title Test case for "testdox" option with dataProvider providing indexed array Bug with "testdox" option with dataProvider providing indexed array not showing data set index. Oct 2, 2018
@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #3321 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3321      +/-   ##
============================================
- Coverage     82.61%   82.59%   -0.03%     
  Complexity     3533     3533              
============================================
  Files           143      143              
  Lines          9331     9331              
============================================
- Hits           7709     7707       -2     
- Misses         1622     1624       +2
Impacted Files Coverage Δ Complexity Δ
src/Util/TestDox/NamePrettifier.php 98.78% <100%> (ø) 36 <0> (ø) ⬇️
src/Framework/TestCase.php 76.14% <0%> (-0.25%) 304% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6564e...c5b1141. Read the comment docs.

@sebastianbergmann sebastianbergmann changed the title Bug with "testdox" option with dataProvider providing indexed array not showing data set index. Incorrect TestDox output for data provider with indexed array Oct 12, 2018
@sebastianbergmann sebastianbergmann added the type/bug Something is broken label Oct 12, 2018
@sebastianbergmann
Copy link
Owner

Merged manually, thanks.

@kubawerlos kubawerlos deleted the bugfix/testdox-with-indexed-data-provider branch October 12, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants