Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing xs:choice #3250

Closed
wants to merge 1 commit into from
Closed

Conversation

theseer
Copy link
Collaborator

@theseer theseer commented Aug 12, 2018

Some xs:sequence nodes of the xsd need xs:choice to make the sort order become irrelevant as PHPUnit doesn't care and the config is perfectly valid either way.

Fixes #3248

@codecov-io
Copy link

codecov-io commented Aug 12, 2018

Codecov Report

Merging #3250 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3250   +/-   ##
========================================
  Coverage      82.3%   82.3%           
  Complexity     3486    3486           
========================================
  Files           140     140           
  Lines          9205    9205           
========================================
  Hits           7576    7576           
  Misses         1629    1629

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a268b...c018fe2. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Merged manually, thanks.

@theseer theseer deleted the xsd-unsorted branch August 12, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants