Do not create cache file by default #3237

[Douglasdc3]

The documentation read this feature is disabled by default it was enabled anyway.

Disable it by default to maintain backwards compatibility and allow tests to run on read only filesystem.

ref: #3237

[codecov-io]

Codecov Report

Merging #3241 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3241      +/-   ##
============================================
- Coverage     82.39%   82.37%   -0.03%     
  Complexity     3508     3508              
============================================
  Files           140      140              
  Lines          9243     9243              
============================================
- Hits           7616     7614       -2     
- Misses         1627     1629       +2

Impacted Files	Coverage Δ	Complexity Δ
src/TextUI/TestRunner.php	63.9% <100%> (-0.17%)	273 <0> (ø)
src/Util/TestResultCache.php	98% <0%> (-2%)	25% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d527f1...fbbbbb3. Read the comment docs.

[kubawerlos]

Can we have the default also in phpunit.xsd?

[sebastianbergmann]

Merged manually, thanks.

[keradus]

:(

is there a plan to enable feature by default for 8.0 ?

[sebastianbergmann]

#3244 :)

[epdenouden]

Nice one, thanks for quickly resolving this.

@keradus Yes it will become a default. Before that let's have a quick think about how to work with readonly filesystems gently. I might take a look at the PHP-CS-Fixer thing, I heard they use a cachefile too

[keradus]

on readonly fs: if cache file was requested, but saving to it failed, it shall trigger the warning message to stderr, but continue with regular flow of application