Fix #2974 - Invalid Chars in JUnit XML #3013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JUnit XML (produced with --log-junit) is invalid (and won't be opened by some programs) if it contains invalid XML characters in the <system-out> node. Fix this by sanitizing text before adding it to the XML.
Codecov Report
@@ Coverage Diff @@
## master #3013 +/- ##
=========================================
Coverage 80.43% 80.43%
Complexity 2827 2827
=========================================
Files 107 107
Lines 7436 7436
=========================================
Hits 5981 5981
Misses 1455 1455
Continue to review full report at Codecov.
|
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit XML (produced with --log-junit) is invalid (and won't be opened by
some programs) if it contains invalid XML characters in the
node. Fix this by sanitizing text before adding it to the XML.
This fixes #2974.