PHPUnit shouldn't crash when a test suite contains both *.phpt files and unconventionally named tests #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les and unconventionally named tests There's no point in calling the TestSuite constructor with any class which is not instance of TestSuite and does not extend TestCase.
stickler-ci
reviewed
Jan 26, 2018
| <?php | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class Issue2972Test extends TestCase |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
Codecov Report
@@ Coverage Diff @@
## master #2973 +/- ##
========================================
Coverage 80.4% 80.4%
- Complexity 2820 2821 +1
========================================
Files 107 107
Lines 7426 7426
========================================
Hits 5971 5971
Misses 1455 1455
Continue to review full report at Codecov.
|
narkq
changed the title
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2972 and probably #2950 .