Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref #2236 - Move status assignment after last occurence of _e AND add… #2940

Closed
wants to merge 1 commit into from

Conversation

Morerice
Copy link

I think that this is what @rtwo was referring to in #2236

@codecov-io
Copy link

codecov-io commented Dec 24, 2017

Codecov Report

Merging #2940 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2940   +/-   ##
=========================================
  Coverage     79.86%   79.86%           
  Complexity     2822     2822           
=========================================
  Files           107      107           
  Lines          7438     7438           
=========================================
  Hits           5940     5940           
  Misses         1498     1498
Impacted Files Coverage Δ Complexity Δ
src/Framework/TestCase.php 66.3% <100%> (ø) 311 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19b93d...dc5925a. Read the comment docs.

@sebastianbergmann sebastianbergmann added the type/bug Something is broken label Dec 24, 2017
@keradus
Copy link
Contributor

keradus commented Dec 27, 2017

as a bug, would be great to fix it on lowest maintained branch, not on not-yet-released phpunit 7 (major, bc breakers)

@sebastianbergmann
Copy link
Owner

Cherry-picked into 6.5 and master, backported to 5.7. Thanks!

@CDJojn
Copy link

CDJojn commented Mar 22, 2018

@bigaltum Is it bug or wanted behavior? We are currently facing this issue, all our failing tests are marked as PASSED (internal state) because of TestCase::hasFailed() returns false...

@sebastianbergmann
Copy link
Owner

@bigaltum @CDJojn Please open a new ticket and provide a minimal, self-contained, reproducing test case that shows your problem.

Without such a minimal, self-contained, reproducing test case I will not be able to investigate this issue.

@CDJojn
Copy link

CDJojn commented Mar 23, 2018

@sebastianbergmann Thank you for your reply. It seems my issue is duplicate of this bug #3031 - comment added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants