Fix for #2922 - incorrect "No tests found in class PHPUnit\Framework\*" which happens when there is a test class with @group and provider throwing exception in it, plus tests are ran with --exclude-group for that group, plus there is another class called later (after handing the class from above), and finally when the name of that another class does not match it's file name

[kubawerlos]

Fixes #2922

I have replaced the silly if in TestSuite.php with more general approach - checking if the class belongs to PHPUnit\Framework.

[codecov-io]

Codecov Report

Merging #2924 into 5.7 will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                5.7    #2924      +/-   ##
============================================
- Coverage     52.38%   52.35%   -0.03%     
  Complexity     2912     2912              
============================================
  Files           110      110              
  Lines          7953     7953              
============================================
- Hits           4166     4164       -2     
- Misses         3787     3789       +2

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/TestSuite.php	71.61% <100%> (ø)	150 <0> (ø)	⬇️
src/Framework/Constraint/ArraySubset.php	86.95% <0%> (-8.7%)	9% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43b6f4...c906d78. Read the comment docs.

[sebastianbergmann]

@kubawerlos Thank you for taking care of this.

I had to adapt the skip condition in addTestFile() from using strpos() and looking at the class name to checking the sourcecode directory for PHPUnit 6 due to namespaces. See https://github.com/sebastianbergmann/phpunit/blob/6.5/src/Framework/TestSuite.php#L363