Fix for declaring test case in data provider #2834
Conversation
| <?php | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class FirstTest extends TestCase |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
| <?php | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class SecondTest extends TestCase |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
Codecov Report
@@ Coverage Diff @@
## 5.7 #2834 +/- ##
============================================
- Coverage 51.18% 51.18% -0.01%
- Complexity 2912 2913 +1
============================================
Files 110 110
Lines 9706 9710 +4
============================================
+ Hits 4968 4970 +2
- Misses 4738 4740 +2
Continue to review full report at Codecov.
|
| <?php | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class FirstTest extends TestCase |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
| <?php | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class SecondTest extends TestCase |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
| <?php | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class FirstTest extends TestCase |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
| <?php | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class SecondTest extends TestCase |
There was a problem hiding this comment.
Each class must be in a namespace of at least one level (a top-level vendor name)
|
Ping @sebastianbergmann |
|
Can you please send a pull request against |
|
@sebastianbergmann done |
src/Framework/TestSuite.php
Outdated
| @@ -292,6 +292,12 @@ public function addTestSuite($testClass) | |||
| */ | |||
| public function addTestFile($filename) | |||
| { | |||
| static $declaredClasses; | |||
There was a problem hiding this comment.
Please do not use a method-local, static variable here.
There was a problem hiding this comment.
@sebastianbergmann done, changed to private, dynamic one.
kubawerlos
deleted the
bugfix/fixing-class-declaration-in-data-provider
branch
#2833