Feature Getopt refactoring each #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
added
the
type/refactoring
|
Thank you! |
|
thanks @eclipxe13 ! 👍 :) |
|
I think we should backport this to PHPUnit 5.7, because the symfony/phpunit-bridge will find the silenced function call (see e.g. https://travis-ci.org/contao/core-bundle/jobs/311481433). What do you think? |
falkenhawk
added a commit
to zf1s/phpunit
that referenced
this pull request
May 8, 2019
- refactored Getopt + tests - each() is deprecated since php 7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves PHPUnit\Util\Getopt uses deprecated each() function #2472.
It is a simple refactory to avoid using
each()function based oncurrent()andnext().It includes more tests to verify how
Getopt::getoptworks.Thanks for your great work and reviewing this PR.