Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception when @testWith annotation contains invalid datasets #1968

Closed
wants to merge 1 commit into from
Closed

Throw exception when @testWith annotation contains invalid datasets #1968

wants to merge 1 commit into from

Commits on Mar 21, 2016

  1. Throw exception when @testwith annotation contains invalid datasets 

    The existing code was silently ignoring invalid JSON if it had
found at least one valid dataset. It was using this behaviour
to detect the end of the @testwith annotation (see for eg the
testTestWithSimpleTextAfter test, which fails if a simple
throw on invalid JSON is used).

This fix treats a line as being part of the @testwith if it begins
with a `[` character - since all datasets are required to be JSON
arrays this should be reliable.

It can then reliably throw if invalid JSON is found for any of the
datasets.
    @acoulton
    acoulton committed Mar 21, 2016
    Copy the full SHA
    9d861b3 View commit details
    Browse the repository at this point in the history