Closes #4735

sebastianbergmann · Jul 19, 2021 · fe06cbe · fe06cbe
1 parent a1c34bd
commit fe06cbe
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/ChangeLog-9.5.md b/ChangeLog-9.5.md
@@ -7,6 +7,7 @@ All notable changes of the PHPUnit 9.5 release series are documented in this fil
 ### Fixed
 
 * [#4720](https://github.com/sebastianbergmann/phpunit/issues/4720): PHPUnit does not verify its own PHP extension requirements
+* [#4735](https://github.com/sebastianbergmann/phpunit/issues/4735): Automated return value generation does not work for stubbed methods that return `*|false`
 
 ## [9.5.6] - 2021-06-23
 

diff --git a/src/Framework/MockObject/Invocation.php b/src/Framework/MockObject/Invocation.php
@@ -148,6 +148,7 @@ public function generateReturnValue()
                 return 0;
 
             case 'bool':
+            case 'false':
                 return false;
 
             case 'array':

diff --git a/tests/unit/Framework/MockObject/MockObjectTest.php b/tests/unit/Framework/MockObject/MockObjectTest.php
@@ -1203,6 +1203,16 @@ public function testMethodThatReturnsIntOrFalseCanBeStubbed(): void
         $this->assertSame(1, $i->returnsIntOrFalse());
     }
 
+    /**
+     * @requires PHP 8
+     */
+    public function testReturnValueCanBeAutomaticallyGeneratedForMethodThatReturnsIntOrFalse(): void
+    {
+        $i = $this->createStub(InterfaceWithMethodsThatDeclareBooleanReturnTypes::class);
+
+        $this->assertFalse($i->returnsIntOrFalse());
+    }
+
     /**
      * @requires PHP 8
      */