Fixed a fatal TypeError when an incorrect file path is given as secon…

…d argument
sebastianbergmann · Apr 30, 2019 · c9fe4f0 · c9fe4f0
1 parent 1f66fc1
commit c9fe4f0
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/TextUI/Command.php b/src/TextUI/Command.php
@@ -778,7 +778,17 @@ protected function handleArguments(array $argv): void
             }
 
             if (isset($this->options[1][1])) {
-                $this->arguments['testFile'] = \realpath($this->options[1][1]);
+                $testFile = \realpath($this->options[1][1]);
+
+                if ($testFile === false) {
+                    $this->exitWithErrorMessage(
+                        \sprintf(
+                            'Cannot open file "%s".',
+                            $this->options[1][1]
+                        )
+                    );
+                }
+                $this->arguments['testFile'] = $testFile;
             } else {
                 $this->arguments['testFile'] = '';
             }

diff --git a/tests/end-to-end/cli/test-file-not-found.phpt b/tests/end-to-end/cli/test-file-not-found.phpt
@@ -0,0 +1,12 @@
+--TEST--
+Test incorrect testFile is reported
+--ARGS--
+--no-configuration tests nonExistingFile.php
+--FILE--
+<?php declare(strict_types=1);
+require __DIR__ . '/../../bootstrap.php';
+PHPUnit\TextUI\Command::main();
+--EXPECTF--
+PHPUnit %s by Sebastian Bergmann and contributors.
+
+Cannot open file "nonExistingFile.php".