Quietly ignore invalid cache entries

sebastianbergmann · Mar 6, 2021 · c443db3 · c443db3
1 parent 6be238e
commit c443db3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/src/Runner/DefaultTestResultCache.php b/src/Runner/DefaultTestResultCache.php
@@ -10,7 +10,6 @@
 namespace PHPUnit\Runner;
 
 use const DIRECTORY_SEPARATOR;
-use function assert;
 use function defined;
 use function dirname;
 use function file_get_contents;
@@ -209,18 +208,17 @@ public function unserialize($serialized): void
 
         if (isset($data['times'])) {
             foreach ($data['times'] as $testName => $testTime) {
-                assert(is_string($testName));
-                assert(is_float($testTime));
-                $this->times[$testName] = $testTime;
+                if (is_string($testName) && is_float($testTime)) {
+                    $this->times[$testName] = $testTime;
+                }
             }
         }
 
         if (isset($data['defects'])) {
             foreach ($data['defects'] as $testName => $testStatus) {
-                assert(is_string($testName));
-                assert($testStatus instanceof TestStatus);
-
-                $this->defects[$testName] = $testStatus;
+                if (is_string($testName) && $testStatus instanceof TestStatus) {
+                    $this->defects[$testName] = $testStatus;
+                }
             }
         }
     }

diff --git a/tests/unit/Runner/DefaultTestResultCacheTest.php b/tests/unit/Runner/DefaultTestResultCacheTest.php
@@ -19,14 +19,11 @@
  */
 final class DefaultTestResultCacheTest extends TestCase
 {
-    /**
-     * @var DefaultTestResultCache
-     */
-    private $subject;
+    private DefaultTestResultCache $subject;
 
     protected function setUp(): void
     {
-        $this->subject = new DefaultTestResultCache();
+        $this->subject = new DefaultTestResultCache;
     }
 
     public function testGetTimeForNonExistentTestNameReturnsFloatZero(): void