Add onlyMethods, addMethods + deprecate setMethods

sebastianbergmann · May 15, 2019 · a58c6d9 · a58c6d9
1 parent 6421ecc
commit a58c6d9
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 10 deletions.
diff --git a/.psalm/baseline.xml b/.psalm/baseline.xml
@@ -201,7 +201,7 @@
     <PossiblyNullPropertyAssignmentValue occurrences="1">
       <code>null</code>
     </PossiblyNullPropertyAssignmentValue>
-    <ArgumentTypeCoercion occurrences="1">
+    <ArgumentTypeCoercion occurrences="2">
       <code>$this->type</code>
     </ArgumentTypeCoercion>
   </file>

diff --git a/src/Framework/MockObject/MockBuilder.php b/src/Framework/MockObject/MockBuilder.php
@@ -170,6 +170,8 @@ public function getMockForTrait(): MockObject
 
     /**
      * Specifies the subset of methods to mock. Default is to mock none of them.
+     *
+     * @deprecated https://github.com/sebastianbergmann/phpunit/pull/3687
      */
     public function setMethods(array $methods = null): self
     {
@@ -185,15 +187,43 @@ public function setMethods(array $methods = null): self
      *
      * @throws RuntimeException
      */
-    public function setRealMethods(array $methods): self
+    public function onlyMethods(array $methods): self
     {
         $reflection = new \ReflectionClass($this->type);
 
         foreach ($methods as $method) {
             if (!$reflection->hasMethod($method)) {
                 throw new RuntimeException(
                     \sprintf(
-                        'Trying to set mock method "%s", but it does not exist in class "%s"',
+                        'Trying to set mock method "%s" with onlyMethods, but it does not exist in class "%s". Use addMethods() for methods that don\'t exist in the class.',
+                        $method,
+                        $this->type
+                    )
+                );
+            }
+        }
+
+        $this->methods = $methods;
+
+        return $this;
+    }
+
+    /**
+     * Specifies methods that don't exist in the class which you want to mock
+     *
+     * @param string[] $methods
+     *
+     * @throws RuntimeException
+     */
+    public function addMethods(array $methods): self
+    {
+        $reflection = new \ReflectionClass($this->type);
+
+        foreach ($methods as $method) {
+            if ($reflection->hasMethod($method)) {
+                throw new RuntimeException(
+                    \sprintf(
+                        'Trying to set mock method "%s" with addMethod, but it exists in class "%s". Use onlyMethods() for methods that exist in the class.',
                         $method,
                         $this->type
                     )

diff --git a/tests/unit/Framework/MockObject/MockBuilderTest.php b/tests/unit/Framework/MockObject/MockBuilderTest.php
@@ -60,30 +60,49 @@ public function testSetMethodsAllowsNonExistentMethodNames(): void
         $this->assertNull($mock->mockableMethodWithCrazyName());
     }
 
-    public function testSetRealMethodsWithNonExistentMethodNames(): void
+    public function testOnlyMethodsWithNonExistentMethodNames(): void
     {
         $this->expectException(RuntimeException::class);
 
         $this->getMockBuilder(Mockable::class)
-          ->setRealMethods(['mockableMethodWithCrazyName'])
+          ->onlyMethods(['mockableMethodWithCrazyName'])
           ->getMock();
     }
 
-    public function testSetRealMethodsWithExistingMethodNames(): void
+    public function testOnlyMethodsWithExistingMethodNames(): void
     {
         $mock = $this->getMockBuilder(Mockable::class)
-            ->setRealMethods(['mockableMethod'])
-            ->getMock();
+                     ->onlyMethods(['mockableMethod'])
+                     ->getMock();
 
         $this->assertNull($mock->mockableMethod());
         $this->assertTrue($mock->anotherMockableMethod());
     }
 
+    public function testAddMethodsWithNonExistentMethodNames(): void
+    {
+        $this->expectException(RuntimeException::class);
+
+        $this->getMockBuilder(Mockable::class)
+             ->addMethods(['mockableMethod'])
+             ->getMock();
+    }
+
+    public function testAddMethodsWithExistingMethodNames(): void
+    {
+        $mock = $this->getMockBuilder(Mockable::class)
+                     ->addMethods(['mockableMethodWithFakeMethod'])
+                     ->getMock();
+
+        $this->assertNull($mock->mockableMethodWithFakeMethod());
+        $this->assertTrue($mock->anotherMockableMethod());
+    }
+
     public function testEmptyMethodExceptionsToMockCanBeSpecified(): void
     {
         $mock = $this->getMockBuilder(Mockable::class)
-            ->setMethodsExcept()
-            ->getMock();
+                     ->setMethodsExcept()
+                     ->getMock();
 
         $this->assertNull($mock->mockableMethod());
         $this->assertNull($mock->anotherMockableMethod());