#3120 reverted InvocationMocker#will() : self - only works on PHP 7.4

I was too eager in using an appropriate type declaration on `InvocationMocker`, but that has to wait for newer PHP releases.
sebastianbergmann · Sep 6, 2019 · 9a1c97a · 9a1c97a
1 parent 21a9c6d
commit 9a1c97a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/.psalm/baseline.xml b/.psalm/baseline.xml
@@ -97,9 +97,29 @@
     <ImplementedReturnTypeMismatch occurrences="1">
       <code>self</code>
     </ImplementedReturnTypeMismatch>
+    <LessSpecificReturnStatement occurrences="8">
+      <code>$this-&gt;will($stub)</code>
+      <code>$this-&gt;will($stub)</code>
+      <code>$this-&gt;will($stub)</code>
+      <code>$this-&gt;will($stub)</code>
+      <code>$this-&gt;will($stub)</code>
+      <code>$this-&gt;will($stub)</code>
+      <code>$this-&gt;will($stub)</code>
+      <code>$this-&gt;will($stub)</code>
+    </LessSpecificReturnStatement>
     <MethodSignatureMismatch occurrences="1">
       <code>InvocationMocker</code>
     </MethodSignatureMismatch>
+    <MoreSpecificReturnType occurrences="8">
+      <code>self</code>
+      <code>self</code>
+      <code>self</code>
+      <code>self</code>
+      <code>self</code>
+      <code>self</code>
+      <code>self</code>
+      <code>self</code>
+    </MoreSpecificReturnType>
     <UndefinedInterfaceMethod occurrences="1">
       <code>registerId</code>
     </UndefinedInterfaceMethod>

diff --git a/src/Framework/MockObject/Builder/InvocationMocker.php b/src/Framework/MockObject/Builder/InvocationMocker.php
@@ -68,7 +68,7 @@ public function id($id): self
         return $this;
     }
 
-    public function will(Stub $stub): self
+    public function will(Stub $stub): Identity
     {
         $this->matcher->setStub($stub);