Closes #4024

sebastianbergmann · Jan 22, 2020 · 93dc317 · 93dc317
1 parent bcf82c2
commit 93dc317
Show file tree

Hide file tree

Showing 18 changed files with 641 additions and 616 deletions.
diff --git a/.psalm/baseline.xml b/.psalm/baseline.xml
@@ -259,7 +259,7 @@
       <code>$option['desc']</code>
     </PossiblyUndefinedArrayOffset>
   </file>
-  <file src="src/TextUI/ResultPrinter.php">
+  <file src="src/TextUI/DefaultResultPrinter.php">
     <PossiblyUndefinedVariable occurrences="1">
       <code>$color</code>
     </PossiblyUndefinedVariable>

diff --git a/ChangeLog-9.0.md b/ChangeLog-9.0.md
@@ -11,6 +11,7 @@ All notable changes of the PHPUnit 9.0 release series are documented in this fil
 ### Changed
 
 * Implemented [#3746](https://github.com/sebastianbergmann/phpunit/issues/3746): Improve developer experience of global wrapper functions for assertions
+* Implemented [#4024](https://github.com/sebastianbergmann/phpunit/issues/4024): Make `PHPUnit\TextUI\ResultPrinter` an interface
 
 ### Removed
 

diff --git a/src/TextUI/Command.php b/src/TextUI/Command.php
@@ -15,7 +15,6 @@
 use PharIo\Version\Version as PharIoVersion;
 use PHPUnit\Framework\Exception;
 use PHPUnit\Framework\Test;
-use PHPUnit\Framework\TestListener;
 use PHPUnit\Framework\TestSuite;
 use PHPUnit\Runner\StandardTestSuiteLoader;
 use PHPUnit\Runner\TestSuiteLoader;
@@ -285,7 +284,7 @@ protected function handleArguments(array $argv): void
         foreach ($this->options[0] as $option) {
             switch ($option[0]) {
                 case '--colors':
-                    $this->arguments['colors'] = $option[1] ?: ResultPrinter::COLOR_AUTO;
+                    $this->arguments['colors'] = $option[1] ?: DefaultResultPrinter::COLOR_AUTO;
 
                     break;
 
@@ -1010,7 +1009,7 @@ protected function handleLoader(string $loaderClass, string $loaderFile = ''): ?
     protected function handlePrinter(string $printerClass, string $printerFile = '')
     {
         if (!\class_exists($printerClass, false)) {
-            if ($printerFile == '') {
+            if ($printerFile === '') {
                 $printerFile = Filesystem::classNameToFilename(
                     $printerClass
                 );
@@ -1044,22 +1043,12 @@ protected function handlePrinter(string $printerClass, string $printerFile = '')
             // @codeCoverageIgnoreEnd
         }
 
-        if (!$class->implementsInterface(TestListener::class)) {
+        if (!$class->implementsInterface(ResultPrinter::class)) {
             $this->exitWithErrorMessage(
                 \sprintf(
                     'Could not use "%s" as printer: class does not implement %s',
                     $printerClass,
-                    TestListener::class
-                )
-            );
-        }
-
-        if (!$class->isSubclassOf(Printer::class)) {
-            $this->exitWithErrorMessage(
-                \sprintf(
-                    'Could not use "%s" as printer: class does not extend %s',
-                    $printerClass,
-                    Printer::class
+                    ResultPrinter::class
                 )
             );
         }