Skip to content

Commit

Permalink
Closes #3353
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastianbergmann committed Oct 17, 2018
1 parent 6034bae commit 2f38210
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions ChangeLog-7.4.md
Expand Up @@ -7,6 +7,7 @@ All notable changes of the PHPUnit 7.4 release series are documented in this fil
### Fixed

* Fixed [#3321](https://github.com/sebastianbergmann/phpunit/pull/3321): Incorrect TestDox output for data provider with indexed array
* Fixed [#3353](https://github.com/sebastianbergmann/phpunit/issues/3353): Requesting less than 16 columns of output results in an error

## [7.4.0] - 2018-10-05

Expand Down
9 changes: 9 additions & 0 deletions src/TextUI/TestRunner.php
Expand Up @@ -158,6 +158,11 @@ public function doRun(Test $suite, array $arguments = [], bool $exit = true): Te

$this->handleConfiguration($arguments);

if ($arguments['columns'] < 16) {

This comment has been minimized.

Copy link
@remicollet

remicollet Oct 18, 2018

Contributor

Shouldn't this take care of the "max" case (issue #3354 )

$arguments['columns'] = 16;
$tooFewColumnsRequested = true;
}

if (isset($arguments['bootstrap'])) {
$GLOBALS['__PHPUNIT_BOOTSTRAP'] = $arguments['bootstrap'];
}
Expand Down Expand Up @@ -354,6 +359,10 @@ public function doRun(Test $suite, array $arguments = [], bool $exit = true): Te
}
}

if (isset($tooFewColumnsRequested)) {
$this->writeMessage('Error', 'Less than 16 columns requested, number of columns set to 16');
}

if ($this->runtime->discardsComments()) {
$this->writeMessage('Warning', 'opcache.save_comments=0 set; annotations will not work');
}
Expand Down

0 comments on commit 2f38210

Please sign in to comment.