Make room to fix #3513 with a color-independent progress spinner

sebastianbergmann · Feb 14, 2019 · 11c1450 · 11c1450
1 parent eeba3b8
commit 11c1450
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/TextUI/TestRunner.php b/src/TextUI/TestRunner.php
@@ -316,6 +316,7 @@ public function doRun(Test $suite, array $arguments = [], bool $exit = true): Te
                 if (isset($originalExecutionOrder) && ($this->printer instanceof CliTestDoxPrinter)) {
                     /* @var CliTestDoxPrinter */
                     $this->printer->setOriginalExecutionOrder($originalExecutionOrder);
+//                    $this->printer->setShowProgressAnimation(true);
                 }
             }
         }

diff --git a/src/Util/TestDox/TestDoxPrinter.php b/src/Util/TestDox/TestDoxPrinter.php
@@ -65,6 +65,11 @@ class TestDoxPrinter extends ResultPrinter
      */
     protected $spinState = 0;
 
+    /**
+     * @var bool
+     */
+    protected $showProgress = true;
+
     /**
      * @param null|resource|string $out
      *
@@ -83,6 +88,11 @@ public function setOriginalExecutionOrder(array $order): void
         $this->enableOutputBuffer     = !empty($order);
     }
 
+    public function setShowProgressAnimation(bool $doShowSpinner): void
+    {
+        $this->showProgress = $doShowSpinner;
+    }
+
     public function printResult(TestResult $result): void
     {
     }
@@ -260,18 +270,28 @@ protected function flushOutputBuffer(): void
 
     protected function showSpinner(): void
     {
+        if (!$this->showProgress) {
+            return;
+        }
+
         if ($this->spinState) {
             $this->undrawSpinner();
         }
+
         $this->spinState++;
         $this->drawSpinner();
     }
 
     protected function hideSpinner(): void
     {
+        if (!$this->showProgress) {
+            return;
+        }
+
         if ($this->spinState) {
             $this->undrawSpinner();
         }
+
         $this->spinState = 0;
     }