Fix: Allow using duration as value for order-by option via CLI

sebastianbergmann · May 5, 2019 · 091216b · 091216b
1 parent 14daebe
commit 091216b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/TextUI/Command.php b/src/TextUI/Command.php
@@ -1158,7 +1158,7 @@ protected function showHelp(): void
   --printer <printer>         TestListener implementation to use
 
   --resolve-dependencies      Resolve dependencies between tests
-  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends
+  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends|duration
   --random-order-seed=<N>     Use a specific random seed <N> for random order
   --cache-result              Write run result to cache to enable ordering tests defects-first
 
@@ -1366,6 +1366,11 @@ private function handleOrderByOption(string $value): void
 
                     break;
 
+                case 'duration':
+                    $this->arguments['executionOrder'] = TestSuiteSorter::ORDER_DURATION;
+
+                    break;
+
                 default:
                     $this->exitWithErrorMessage("unrecognized --order-by option: $order");
             }

diff --git a/tests/end-to-end/help.phpt b/tests/end-to-end/help.phpt
@@ -88,7 +88,7 @@ Test Execution Options:
   --printer <printer>         TestListener implementation to use
 
   --resolve-dependencies      Resolve dependencies between tests
-  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends
+  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends|duration
   --random-order-seed=<N>     Use a specific random seed <N> for random order
   --cache-result              Write run result to cache to enable ordering tests defects-first
 

diff --git a/tests/end-to-end/help2.phpt b/tests/end-to-end/help2.phpt
@@ -89,7 +89,7 @@ Test Execution Options:
   --printer <printer>         TestListener implementation to use
 
   --resolve-dependencies      Resolve dependencies between tests
-  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends
+  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends|duration
   --random-order-seed=<N>     Use a specific random seed <N> for random order
   --cache-result              Write run result to cache to enable ordering tests defects-first