Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix fatal syntax error "unexpected '-', expecting '{'" #424

Merged
merged 1 commit into from Aug 7, 2018
Merged

Fix fatal syntax error "unexpected '-', expecting '{'" #424

merged 1 commit into from Aug 7, 2018

Conversation

Hecke29
Copy link
Contributor

@Hecke29 Hecke29 commented Jul 18, 2018

caused by special chars in wsdl-filename
This might also fix #357

Stumbled over that bug today. Remote file could be load via http (http://example.org/soap.wsdl) but saved as local file with name (/home/user/my-dir/acme-soap.wsdl) lead to that error. Guessed that it has something todo with the - in the directory- or filename and found it.

…ial chars in wsdl-filename

This might also fix #357
@Hecke29
Copy link
Contributor Author

Hecke29 commented Jul 18, 2018

travis reporting ParseError: syntax error, unexpected 'ogle' (T_STRING), expecting '{' which is interesting. Tests are fine locally (OSx). Will try on an ubuntu computer...

@Hecke29
Copy link
Contributor Author

Hecke29 commented Jul 18, 2018

well... Let's forget about this shameful uncomitted fix...

@Hecke29 Hecke29 closed this Jul 18, 2018
@Hecke29
Copy link
Contributor Author

Hecke29 commented Jul 18, 2018

Ok, it's not that shameful that I thought: The unit test is here but the fix would be best in the TestCase.php of phpunit main repository...

@Hecke29
Copy link
Contributor Author

Hecke29 commented Jul 18, 2018

This belongs to sebastianbergmann/phpunit#3217

@Hecke29
Copy link
Contributor Author

Hecke29 commented Jul 19, 2018

will fix this in phpunit 7.2 (mock-object project was merged into main project)

@Hecke29 Hecke29 closed this Jul 19, 2018
@keradus
Copy link

keradus commented Jul 19, 2018

shall be opened, so PHPUnit <7.2 would benefit from fix as well

@Hecke29
Copy link
Contributor Author

Hecke29 commented Jul 19, 2018

Please notice that this are just tests and the fix for older versions is in the main repository: sebastianbergmann/phpunit#3217
Thus that PR should be opened again too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants