Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fixed PHPUnit\Framework\MockObject\Invocation usage in Matcher/* classes #391

Merged

Conversation

e-vyatkin
Copy link
Contributor

Not all classes was correctly refactored for namespace usage

@codecov-io
Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #391   +/-   ##
=========================================
  Coverage     72.75%   72.75%           
  Complexity      438      438           
=========================================
  Files            27       27           
  Lines          1226     1226           
=========================================
  Hits            892      892           
  Misses          334      334
Impacted Files Coverage Δ Complexity Δ
src/Matcher/AnyParameters.php 0% <0%> (ø) 2 <1> (ø) ⬇️
src/Matcher/InvokedCount.php 80% <100%> (ø) 9 <4> (ø) ⬇️
src/Matcher/MethodName.php 93.33% <100%> (ø) 5 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93faa8...de4bea1. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Can you please provide an example test case which does not work without this patch? Thanks!

@sebastianbergmann
Copy link
Owner

@zhem4ag Can you please answer my question? Thanks!

@e-vyatkin
Copy link
Contributor Author

Strange, I could reproduce only on single environment, but there exist conflict with phpunit installed separately in system.

Probably this PR in not needed, cause it works on other environments, where I checked.

@sebastianbergmann
Copy link
Owner

Thank you for your feedback. Please open a new issue and/or pull request if you are able to reproduce an issue.

@sebastianbergmann
Copy link
Owner

This could be the fix for #394.

@misyaath
Copy link

Perfect its works now Thank you so much

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants