Update XML printerClass default value #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor update to the XML configuration section of the documentation for the
printerClassattribute. TheResultPrinterclass was changed to be an interface and the default printer class updated toDefaultResultPrinterin the code and the XSD (Here is the PR that this update was made in for reference sebastianbergmann/phpunit#4024).In addition to updating the Default value for
printerClassin the docs I've updated the description to refer to it as an interface and have made the wording consistent with the description of thetestSuiteLoaderClasswhich also has an interface and standard class.Looking through PHPUnit it appears that the first version of the code to convert the class
ResultPrinterto an interface was PHPUnit 9.0.0 which is why I have opened this PR to only be merged into branch 9.5.