Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw: mark as executable expression line regardless of type #969

Merged

Conversation

Slamdunk
Copy link
Contributor

Fix bug found in infection/infection#1778

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #969 (a069b96) into 9.2 (3f893e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                9.2     #969   +/-   ##
=========================================
  Coverage     84.30%   84.31%           
  Complexity     1178     1178           
=========================================
  Files            59       59           
  Lines          4219     4221    +2     
=========================================
+ Hits           3557     3559    +2     
  Misses          662      662           
Impacted Files Coverage Δ
...c/StaticAnalysis/ExecutableLinesFindingVisitor.php 98.90% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastianbergmann sebastianbergmann merged commit 5662cf9 into sebastianbergmann:9.2 Dec 16, 2022
@Slamdunk Slamdunk deleted the throw_with_variable branch December 16, 2022 13:07
@romm
Copy link

romm commented Dec 16, 2022

I can confirm the fix works, thanks @Slamdunk!

@Slamdunk
Copy link
Contributor Author

@sebastianbergmann may I ask you a release for this please? That would be very welcome 🙏

@sebastianbergmann
Copy link
Owner

@sebastianbergmann may I ask you a release for this please?

Done.

@Slamdunk
Copy link
Contributor Author

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants