Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float export precision #47

Merged
merged 1 commit into from Sep 14, 2022
Merged

Fix float export precision #47

merged 1 commit into from Sep 14, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Sep 5, 2022

related/needed for sebastianbergmann/phpunit#4972

also add tests for NAN and microoptimize bool dump

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #47 (4ba13fc) into 3.1 (77200c5) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1      #47      +/-   ##
============================================
+ Coverage     96.03%   96.15%   +0.12%     
  Complexity       55       55              
============================================
  Files             1        1              
  Lines           126      130       +4     
============================================
+ Hits            121      125       +4     
  Misses            5        5              
Impacted Files Coverage Δ
src/Exporter.php 96.15% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mvorisek
Copy link
Contributor Author

mvorisek commented Sep 8, 2022

Hi @sebastianbergmann, can you please look into this PR? For me, the limited exported float precision is a clear bug. a) the exported precision should not depends on php.ini/local configuration, b) full precision should always be exported, otherwise two export numbers can be the same for different values.

@mvorisek
Copy link
Contributor Author

@sebastianbergmann can I please ask you to merge this bugfix PR and tag a new release?

@sebastianbergmann
Copy link
Owner

I am sorry, but "also add tests for NAN and microoptimize bool dump" throws me off. Please propose these changes in separate pull requests.

@mvorisek
Copy link
Contributor Author

I am sorry, but "also add tests for NAN and microoptimize bool dump" throws me off. Please propose these changes in separate pull requests.

done in #48

NAN/INF - this PR is about exporting full precision of float type and NAN/INF tests are related, is it ok to keep them in this PR?

@sebastianbergmann sebastianbergmann merged commit a9f4590 into sebastianbergmann:3.1 Sep 14, 2022
@sebastianbergmann
Copy link
Owner

Thank you.

Versions 3.1.5 and 4.0.5 have been tagged, sebastianbergmann/phpunit#4972 can be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants