New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix php ini parsing from the CLI #62
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you please send this against the |
I'll rebase and fix the conflicts when I get to the computer |
Added the suggestion by Joe Watkins in sebastianbergmann/phpunit#4664 for parsing settings.
I messed something up with rebasing (probably because I've never rebased against a tag 😬). I'll open up a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (possible) fix for the PHPUnit issue sebastianbergmann/phpunit#4664
I've added the suggestion by @krakjoe (link) and some tests to cover this part of the code.
I've run the tests on the PHPUnit locally on the latest branch to check if anything broke, and the existing tests passed. I guess this should be tested a bit thoroughly.
When I ran the tests on the PHPUnit repo and put the breakpoint to inspect the result of merging the settings with
getCurrentSettings
method in theAbstractPhpProcess.php
file inside thegetCommand
method I could see my xdebug settings correctly parsed, so I think there should be no breaks.I had to add the updated code manually inside the vendor file to test this because I got a composer error when trying to use my branch instead of the v6 for the
php-code-coverage
package.This is the image of the breakpoint and part of the
$settings
array:I'd love to have somebody test it a bit more just to be sure.
Oh and I'd love to add a co-authored commit for @krakjoe but I'm not sure what the no-reply email is 🙈 I can update the commit message to add it once I find out the correct email 🙂