New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mod] simple theme: smaller build #566
Conversation
remove: * searx/static/themes/simple/js/searxng.head.js * searx/static/themes/simple/js/searxng.js * searx/static/themes/simple/css/searxng-rtl.css * searx/static/themes/simple/css/searxng.css These files are never used. About the js files: the .map files references the sources instead of the concated version.
I pushed 8212586 to remove this files from the static folder.
this works, as long as we have the
To get #141 done, we need to copy these files to
I don't think so, cleaning up the source files is IMO not related to a StyleGuide
No need for, don't lets waste time with this theme. We should make simple theme the default theme, then we can remove oscar theme and then we can assemble a build chain in With other words: oscar is in the way to have a clean build chain for client side stuff / making simple theme to the default (and removing oscar) should be prioritized. |
remove: searx/static/themes/simple/js/searxng.js searx/static/themes/simple/js/searxng.head.js searx/static/themes/simple/css/searxng-rtl.css searx/static/themes/simple/css/searxng.css Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
c6a3b54
to
8212586
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dalf, this PR animated me to add various improvements on top of branch. Please read through the commit messages and the comments from mine. Adopt what you think is good and drop what you don't think is good.
ab45474
to
8212586
Compare
@dalf is it OK, when we merge this PR? .. I have some patches in the loop where the merge of this PR is needed for. |
What does this PR do?
remove:
These files are never used.
About the js files: the .map files references the sources instead of the concated version.
Why is this change important?
Remove some useless files from the built files.
Draft because:
How to test this PR locally?
make run
, check Javascript is working (clear a search, image detail, map)Author's checklist
Except
searx/static/themes/simple/css/images
, all files are now built from the sources.Related issues
Related to #141