[mod] simple theme: drop img_src from default results #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of img_src AND thumbnail in the default results makes no sense (only a thumbnail is needed). In the current state this is rather confusing, because img_src is displayed like a thumbnail (small) and thumbnail is displayed like an image (large). Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
dalf
reviewed
May 12, 2024
dalf
reviewed
May 12, 2024
|
I agree the names are confusing, however I don't think the
various API from the video engines use the term "thumbnails". I'm not sure how to resolve this confusion. |
return42
commented
May 13, 2024
|
I have not test the PR, but the whole thing makes sense. |
return42
commented
May 13, 2024
Bnyro
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
img_srcAND thumbnail in the default results makes no sense (only a thumbnail is needed). In the current state this is rather confusing, becauseimg_srcis displayed like a thumbnail (small) andthumbnailis displayed like an image (large).