-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading time information #3102
base: master
Are you sure you want to change the base?
Conversation
2 decimals are probably more than enough :) And in my opinion, this should be hidden at all by default and expandable with an arrow at the right, next to "Number of results: ...". |
Hehe yeah so I didn't bother to change it to a human readable format yet; We could either show it in seconds like: "2.45 seconds", "0.67 seconds" or in milliseconds like: "2450 milliseconds", "670 milliseconds" - I personally prefer seconds.
how about we format it like this: "Number of results: 2,450,000; Took 2.45 seconds" - 2.45 seconds being the longest engine and this whole paragraph is expandable then? |
Same, seconds are more user friendly.
That sounds good to me 👍 |
What does this PR do?
To see the durations it took each engine to load, this PR adds this information to the sidebar.
This is still a WIP, I opened this draft to see whether this is heading into the right direction :D.
Why is this change important?
All major search engines show their duration. Having easy access also makes it more transparent to users what engine may be causing long loading times.
How to test this PR locally?
Run like normally
Related issues
Closes #3092