Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading time information #3102

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

Myzel394
Copy link
Contributor

@Myzel394 Myzel394 commented Jan 6, 2024

What does this PR do?

To see the durations it took each engine to load, this PR adds this information to the sidebar.
This is still a WIP, I opened this draft to see whether this is heading into the right direction :D.

Why is this change important?

All major search engines show their duration. Having easy access also makes it more transparent to users what engine may be causing long loading times.

How to test this PR locally?

Run like normally

Related issues

Closes #3092

@Myzel394
Copy link
Contributor Author

Myzel394 commented Jan 6, 2024

Here are screenshots, remember that this is still a draft and I will definitely need to adjust the styling, tags etc:

image

(look at the sidebar at the right)

image

(this is what it looks like when expanded)

@Bnyro
Copy link
Member

Bnyro commented Jan 7, 2024

2 decimals are probably more than enough :)

And in my opinion, this should be hidden at all by default and expandable with an arrow at the right, next to "Number of results: ...".

@Myzel394
Copy link
Contributor Author

Myzel394 commented Jan 7, 2024

2 decimals are probably more than enough :)

Hehe yeah so I didn't bother to change it to a human readable format yet; We could either show it in seconds like: "2.45 seconds", "0.67 seconds" or in milliseconds like: "2450 milliseconds", "670 milliseconds" - I personally prefer seconds.

And in my opinion, this should be hidden at all by default and expandable with an arrow at the right, next to "Number of results: ...".

how about we format it like this:

"Number of results: 2,450,000; Took 2.45 seconds" - 2.45 seconds being the longest engine and this whole paragraph is expandable then?

@Bnyro
Copy link
Member

Bnyro commented Jan 7, 2024

Hehe yeah so I didn't bother to change it to a human readable format yet; We could either show it in seconds like: "2.45 seconds", "0.67 seconds" or in milliseconds like: "2450 milliseconds", "670 milliseconds" - I personally prefer seconds.

Same, seconds are more user friendly.

"Number of results: 2,450,000; Took 2.45 seconds" - 2.45 seconds being the longest engine and this whole paragraph is expandable then?

That sounds good to me 👍

@Myzel394
Copy link
Contributor Author

Myzel394 commented Jan 7, 2024

Alright, so that's what it looks like now:

image

image

although it feels too light for me; search engines usually show this beneath the input. However, in this case I don't know where to reasonably put the detailed list of engines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show duration per engine / and in total
2 participants