-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mod] Move static preference URLs back to General in Preferences and apply CSS #3026
base: master
Are you sure you want to change the base?
Conversation
48c0f31
to
6980bdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clean up not related patches and fix conflicts I rebased this branch.
I think it makes sense to isolate <div class="saved_prefs_url_card">
in a dedicated url_card.html
file.
I personally think that the URL belongs thematically in the "cookies" tab, the URL is not related to settings in the "general" tab .. but the decision is not up to me :)
6980bdd
to
9716b8b
Compare
e910db5
to
bbca084
Compare
@obfuscated-loop to fix conflicts with current masters I rebased this branch. |
From the technical point of view this PR LGTM .. but I have a doubt we really want to merge this change in the UI .. @dalf @unixfox @mrpaulblack from my comment above ..
I see some drawbacks in this change
I'm sorry but from my side I want to vote against this change .. I would therefore like to ask you to decide on the further progress and merge of this PR. |
Has always worked great like this for 7 years for SearX (first appeared in searx/searx@38d6ba4) and nobody ever complained. All the claims are valid for newbies users BUT newbies users do not use preferences. They just use the default settings and that's it. Like I said, if we hide this very useful feature under "cookies" I'm pretty sure that users that do not store cookies permanently won't discover this feature. And this represents a huge chunk of our user base, Cookie AutoDelete is one of the most used extensions on the Mozilla addons store. If one day we get complaints, I'm ok to revisit this feature. Until then, I would like to "revert" to the place where this setting was originally placed before we forked SearX. |
Could you please rebase the PR @obfuscated-loop :)? I'll merge it as soon as it's rebased. Thank you. |
I agree 100% with @return42 on this PR. Additionally we should keep in mind that
In my opinion, the Cookies tab would be well suited for being renamed to "Backup and Restore" to be even easier to understand for new users. |
What does this PR do?
This moves the static/saved preference URLs to the General tab. See below:
Why is this change important?
A lot of people, including myself, do not enable or remember cookies across browsing sessions. The static URL allows for people to set-up their browser in a way where they can search with their desired preferences without ever using any type of local storage (apart from storing the URL and parameters as say a bookmark or search engine within their browser). Therefore, it should not be placed in the Cookies tab as it may go unseen.
How to test this PR locally?
Goto
Preferences > General
and look at the bottom of the page - I have also implemented a dark-mode background for the card.Related issues
Closes #2940