-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show duration per engine / and in total #3092
Comments
And what if some engines run into timeout?
Sure, why not .. feel welcome 👍 .. to have a POV concept is most often better and can avoid dumb questions like mine from above :) |
It seems like there is already such a mechanism implemented - is there some reason why it's not being shown in the frontend? Otherwise, I'd simply use that and just add it to the renderer |
See searx/searx#1637 From my experience, the "usual" response is important, not a one time request. By usual I mean the median, the quartile, or even the average. This is what is shown in the preference. @return42 I let you decide |
Sorry for being slow in uptake ... As far as I can tell, we have
What @Myzel394 asked for is more or less the "duration of a individual query". Most often, when one ore more engines run into timeout without response, this duration is dominated by max timeout .. that is why I asked for:
Since this question has not been answered, it is not clear to me what @Myzel394 has in mind .. a POC (a draft PR) might clarify .. or a more detailed concept .. whatever.
I think we should not decide before the idea behind / the concept is clear. |
Isn't this already implemented? I'm specifically talking about the add_timing method, don't we need to simply show these values in the frontend?
I'd show the longest duration under the input; if there's a timeout, this means the timeout is the longest duration. |
The time recording per engine is implemented, but it will take a few more lines of code to determine the maximum time of all engines used in the search query and display it in the user interface.
I don't have an overview yet, but I think the times of engines with a timeout are not recorded by the method. May you implement your POC and we discuss the details of the code in the PR? |
Is your feature request related to a problem? Please describe.
Google and other engine show the duration it took them to load the results:
Describe the solution you'd like
Add a same hint for the duration of the engine that took the longest to respond beneath the search input. Show a detailed view about the duration of each engine on the right side.
Describe alternatives you've considered
Additional context
I can try to open a PR if you're okay with this :)
The text was updated successfully, but these errors were encountered: