Add a feature to ignore empty path segments (// in path). #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new `ignore-empty-path-segments` feature is enabled, multiple leading slashes at the start of the path are ignored (the first segment starts after them), and multiple slashes at the end of any matched segment are ignored (so the next segment starts after them). In addition, the `end` filter will ignore multiple slashes that follow the final segment. Both the `fullpath` and `tail` filters will still return any multiple slashes in their matched text, but their `segments` iterator will ignore the empty segments (in fact it does this today even without this feature being set). This change does _not_ include this feature in the list of default features. This change includes path filter testing on paths with multiple slashes in them. This change fixes seanmonstar#738.
|
@seanmonstar This PR does not update docs. If you are interested in merging it but need me to write docs first just let me know. All review comments appreciated. |
This fixes the new compiler warning about implicit associated type bounds, as per seanmonstar#1020 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new
ignore-empty-path-segmentsfeature is enabled, multiple leading slashes at the start of the path are ignored (the first segment starts after them), and multiple slashes at the end of any matched segment are ignored (so the next segment starts after them). In addition, theendfilter will ignore multiple slashes that follow the final segment. Both thefullpathandtailfilters will still return any multiple slashes in their matched text, but theirsegmentsiterator will ignore the empty segments (in fact it does this today even without this feature being set).This change does not include this feature in the list of default features.
This change includes path filter testing on paths with multiple slashes in them.
This change fixes #738.