Use status code for trace filter log level / message. #981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
warp::trace()
filter assumes that:However, this doesn't work well with custom rejections:
Normally you will
.recover()
the rejection and return a 4xx/5xx reply.warp::trace()
will currently log INFO / "finished processing with success", as if everything is OK, whereas it should log WARN/ERROR, same as for known rejections.This PR changes the logging to be based only on the status code.