Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace futures with futures-util #906

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Replace futures with futures-util #906

merged 2 commits into from
Oct 10, 2021

Conversation

nylonicious
Copy link
Contributor

Replace usage of futures with futures-util crate.

  • cargo tree looks much cleaner
  • Removes unused futures-io dependency.

@nylonicious
Copy link
Contributor Author

I think it should be fine now.

jxs
jxs approved these changes Oct 10, 2021
View reviewed changes
Copy link
Collaborator

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks!

@jxs jxs merged commit 25eedf6 into seanmonstar:master Oct 10, 2021
@FSMaxB FSMaxB mentioned this pull request Oct 10, 2021
Merged
@nathanfranke nathanfranke mentioned this pull request May 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nylonicious @jxs