Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TLS ciphersuites configurable #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlessandroBono
Copy link

Hello, I would like to make the TLS ciphersuites configurable. Let me know how to proceed if you are not comfortable to expose SupportedCipherSuite from rustls.

Let the users specify what ciphersuites to use.
@AlessandroBono AlessandroBono changed the title server,tls: Make TLS ciphersuites configurable Make TLS ciphersuites configurable Aug 18, 2021
@jxs
Copy link
Collaborator

jxs commented Aug 23, 2021

Hi, and thanks for the interest!
Yeah ideally we don't want to expose internal dependencies to avoid them introducing breaking changes. But this would involve three indirections right? SupportedCipherSuite and Tls12CipherSuite /Tls13CipherSuite honestly I'd suggest punting this one, wdyt @seanmonstar?
Meanwhile if you convert your warp filters to Service and roll them on Hyper with tokio_rustls TlsAcceptor see here also for an axum example on how to that as serve_connection accepts a Service

@seanmonstar
Copy link
Owner

Yea, I agree with @jxs. We've purposefully not exposed the rustls dependency, which allows us to upgrade to new versions transparently. So, I wouldn't want to expose the SupportedCipherSuite type.

We could consider allowing you to just pass a list of strings, and parse them internally. I don't know if that's a good idea, just one I had. The other alternative is what we've suggested for anyone needing more advanced configuration: convert the filters into a service using warp::service, and then use rustls and hyper to make the listener part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants