Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expanded documentation on how to handle rejections #876

Merged
merged 2 commits into from
Jul 1, 2021
Merged

expanded documentation on how to handle rejections #876

merged 2 commits into from
Jul 1, 2021

Conversation

aujxn
Copy link
Contributor

@aujxn aujxn commented Jun 29, 2021

I saw an easy open issue #126 to expand the docs about handling rejections. I'm new to the library but would like to get involved with the project.

jxs
jxs requested changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks for getting this started! 👍 Only missing fixing the issues reported by CI and a couple of notes I left

src/reject.rs Outdated Show resolved Hide resolved
src/reject.rs Outdated Show resolved Hide resolved
@jxs jxs added the waiting-on-author awaiting some action (such as code changes) from the PR or issue author. label Jun 30, 2021
@aujxn
Copy link
Contributor Author

aujxn commented Jul 1, 2021

Awesome! Thanks for the help, cargo test succeeds now I should have tried that before submitting the PR.

@aujxn aujxn requested a review from jxs July 1, 2021 20:38
@jxs jxs merged commit 5a5dba0 into seanmonstar:master Jul 1, 2021
@jxs
Copy link
Collaborator

jxs commented Jul 1, 2021

awesome, thanks! 🚀

@jxs jxs mentioned this pull request Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
waiting-on-author awaiting some action (such as code changes) from the PR or issue author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aujxn @jxs