Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2h keepalive by default #853

Closed
wants to merge 1 commit into from

Conversation

jq-rs
Copy link

@jq-rs jq-rs commented May 18, 2021

Add 2h keepalive by default to drop unused TCP sessions (e.g. behind a firewall).

Fix unused deprecation error given by new compilers.

…firewall).

Fix unused deprecation error given by new compilers.
@jq-rs
Copy link
Author

jq-rs commented May 18, 2021

Fixes #854. New 0.1.x release is kindly requested if this PR is approved.

@jxs
Copy link
Collaborator

jxs commented May 18, 2021

Hi, and thanks for the PR. I wonder if we should also allow for the user to configure it via Server. CC @seanmonstar

src/reject.rs Show resolved Hide resolved
@jxs jxs added the waiting-on-reviewer Awaiting review from the assignee but also interested parties. label Jun 5, 2021
@jq-rs
Copy link
Author

jq-rs commented Jul 2, 2021

If the 2 h default is not acceptable, I can certainly implement an API, please do suggest what kind of API would be preferable. To me, this feature itself is a must-have for public internet web servers.

@jxs
Copy link
Collaborator

jxs commented Jul 2, 2021

if you are on a rush, you can convert your warp filters to Service and set the keepalive on hyper

@jq-rs
Copy link
Author

jq-rs commented Dec 1, 2023

Configurable solution available in #1075, closing this.

@jq-rs jq-rs closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-reviewer Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants