Skip to content

Reexport http2 feature #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Reexport http2 feature #836

merged 4 commits into from
Jun 8, 2021

Conversation

In-line
Copy link
Contributor

@In-line In-line commented Apr 23, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@apiraino
Copy link

apiraino commented May 11, 2021

@In-line nice suggestion 👍

following your link I've tried excluding http2 from Warp but I couldn't get rid of it. My Cargo.toml liiks like:

[dependencies.warp]
version = "0.3.1"
default-features = false

[dependencies.hyper]
version = "0.14.7"
default-features = false
features = ["stream", "http1", "tcp", "client"]

Did you manage to exclude http2 in your build?

thanks

To clarify, here's what I see:

$ cargo tree -d
...
└── warp v0.3.1
...
    ├── hyper v0.14.7
...
    │   ├── h2 v0.3.2
...

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jxs
Copy link
Collaborator

jxs commented Jun 4, 2021

yeah io-util needs to be added to tokio features.
tbh I don't now how this compiles as warp::filters::fs uses AsyncSeekExt

@jxs jxs added the waiting-on-author awaiting some action (such as code changes) from the PR or issue author. label Jun 4, 2021
In-line added 2 commits June 8, 2021 18:06

Verified

This commit was signed with the committer’s verified signature.
In-line Alik Aslanyan

Verified

This commit was signed with the committer’s verified signature.
In-line Alik Aslanyan
@jxs jxs merged commit 316f568 into seanmonstar:master Jun 8, 2021
@jxs
Copy link
Collaborator

jxs commented Jun 8, 2021

thanks!

@In-line In-line deleted the patch-1 branch June 9, 2021 03:44
seanmonstar added a commit that referenced this pull request Nov 4, 2021
seanmonstar added a commit that referenced this pull request Nov 4, 2021
@tbu- tbu- mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author awaiting some action (such as code changes) from the PR or issue author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants