WIP A Result can be a Reply #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide `impl Reply for Result<T, E>` where both `T` and `E` implements Reply. This impl makes no difference between an Ok and an Err, but calls `into_response` for the contained data of either. If an error should be logged, that is the responsibility of the `Reply` impl on the `E` type.
|
Hm. Turns out that a) this is a duplicate of #458 and b) that PR also includes the Only problem with that PR is that it is from February and have merge conflicts. But they should be solvable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
impl Reply for Result<T, E>where bothTandEimplements Reply. This impl makes no difference between an Ok and an Err, but callsinto_responsefor the contained data of either. If an error should be logged, that is the responsibility of theReplyimpl on theEtype.This is testing my suggestion #712 (comment) .
To be really useful, it needs a way to use
async fn foo(...) -> impl Replyas an handler. Filter.mapdoes not do async while.and_thenneeds aResule<impl Reply, Rejecttion>. Is there a middle version?