Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Reply impl for Box<dyn Reply> #450

Merged
merged 1 commit into from Feb 19, 2020
Merged

Generalize Reply impl for Box<dyn Reply> #450

merged 1 commit into from Feb 19, 2020

Commits on Feb 19, 2020

  1. Generalize Reply impl for Box<dyn Reply> 

    We had a case where we were boxing up replies, and needed them to impl `Send + Sync` to use in other code. `Box<dyn Reply + Send + Sync>` unfortunately doesn't implement `Reply`, because the impl is too specific. This generalizes the impl of `Reply` to include any `Box<T>` where `T: Reply + ?Sized`.
    @mikeyhew
    mikeyhew committed Feb 19, 2020
    Copy the full SHA
    2d51a10 View commit details
    Browse the repository at this point in the history