feat: Add a or! macro to make or chaining more readable #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some earlier discussions about more complicated macros (#26 and #395). But I believe a simple
or!
macro is quite useful on its own as it lets long.or
chains be written without having the first filter being aligned differently or.or
getting lost in the noise.(Originally I called this
choice!
because of the equivalent macro I use incombine
https://docs.rs/combine/4.0.1/combine/macro.choice.html butor!
is probably more understandable. It could also be written as a function, using tuples to fake varargs https://docs.rs/combine/4.0.1/combine/fn.choice.html)