New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Param filter with user-defined rejection #293
base: master
Are you sure you want to change the base?
Conversation
Playing around with this a bit, I'm not sure it makes sense to have users implement their own So, perhaps it makes more sense to have |
I'm not quite sure what you mean by this. However, relatedly, master has just seen a refactor of the rejection system which would affect this (#311). |
Ok, I'll look at the new rejection system. |
10ed1dd
to
1891d5f
Compare
I've rebased on master. In this implementation, the user just has to implement |
And it seems like you no longer need to implement |
1891d5f
to
50dd90c
Compare
41ecf31
to
ef5b1cd
Compare
It's been a while since this PR was submitted, I've updated it to better reflect the latest Quick summary:
I see that |
Hi, and sorry for the delay! So if I understand correctly what you are trying to achieve is being able to replace a |
updates
filters::param2
:param_with_err
. This still doesn't quite feel right to me, so let me know if there's other suggestions.Rejection
directly fromFromStr
Err
, instead converting theErr
to aCause
and always returning anot found
Rejection
.Let me know if this is the idea you had from #255.