ECC private keys support for tls feature
#1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It adds support for `ECC` private keys when enabling the `tls` feature. This is particularly useful when generating private keys for example using clients like `Lego ACME` which defaults to `EC256` keys changelog: - ecc private keys support - refactor `TlsConfigError` to reflect intended changes - tokio-rustls 0.24 and subsequent `client_auth` updates
joseluisq
commented
Jun 30, 2023
Closed
|
Is there anything for the author of this PR to do (maybe resolve conflicts) or would it be possible to maybe get this reviewed and merged please? |
|
Oh no please don't say this is a breaking change because of the dependency bump... |
seanmonstar
approved these changes
Oct 8, 2023
|
Looks like there's merge conflicts, if you resolve and ping me, I'll click merge :) |
Conflicts gone. Let me know if there is something else to do :). |
seanmonstar
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ECC private keys when enabling the
tlsfeature.It is particularly useful when generating private keys using some client tools like for example
Lego ACMEwhich defaults toEC256keys.Changelog:
TlsConfigErrorto reflect intended changestokio-rustls 0.24and subsequentclient_authupdates