Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsound lock guard: Remove Send and Sync autotraits from the lock guard #8

Merged
merged 1 commit into from Jan 6, 2023
Merged

Fix unsound lock guard: Remove Send and Sync autotraits from the lock guard #8

merged 1 commit into from Jan 6, 2023

Commits on May 29, 2022

  1. Remove Send and Sync autotraits from the lock guard 

    Having Send on the lock guard is unsound.
Having Sync on the lock guard is unsound, unless T is Sync.

Normally this should use negative trait impls to get rid of Send and Sync.
However, negative trait impls are not fully stabilized, yet.
Use a phantom pointer instead. That's a bit overly strict in that it also removes Sync, if T is Sync.
    @mbuesch
    mbuesch committed May 29, 2022
    Configuration menu
    Copy the full SHA
    ec2a993 View commit details
    Browse the repository at this point in the history