Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused sync_wrapper #2229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tottoto
Copy link

@tottoto tottoto commented Mar 30, 2024

sync_wrapper crate seems not to be used.

@seanmonstar
Copy link
Owner

Oh it's not used? It probably should be, so that reqwest::Body can allow !Sync streams.

@paolobarbolini
Copy link
Contributor

I've tried reintroducing it doesn't look possible because of the functions taking shared references https://github.com/paolobarbolini/reqwest/tree/unsync-body

@musicinmybrain
Copy link

musicinmybrain commented Apr 28, 2024

If you do end up reintroducing it, please update the dependency to 1.0.0 or later. This doesn’t involve any incompatible changes: the only change from 0.1.2 to 1.0.0 was replacing with ' in the description in Cargo.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants