Remove the need for sync on stream methods #2205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Mar 25, 2024
| @@ -327,7 +327,6 @@ fn _assert_impls() { | |||
| assert_sync::<Error>(); | |||
|
|
|||
| assert_send::<Body>(); | |||
| assert_sync::<Body>(); | |||
There was a problem hiding this comment.
Unfortunately this would be a breaking change :(
There was a problem hiding this comment.
Are you sure? I am not a Rust pro so I am probably wrong, but since I am removing a trait constraint to a parameter I was expecting this to be fine ?
Since all structs implementing TryStream+Send+Sync will implement TryStream+Send.
There was a problem hiding this comment.
Since all structs implementing TryStream+Send+Sync will implement TryStream+Send.
Absolutely, but remember that Body isn't just an input for requests; it's also an output for response. Removing Sync from Body would disrupt users who rely on the body being Sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes reqwest body stream compatible with Axum body stream.