Show timeout duration in error messages #2148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proof of concept to add the timeout duration to the error message. This helps users understand why the operation failed. Are you interested in such a change? In this case i would polish the code to make it ready to be reviewed and merged. Before: ``` 馃挜 my-app failed Caused by: Network request failed Caused by: error sending request for url (https://httpbin.org/): operation timed out Caused by: operation timed out ``` After: ``` 馃挜 my-app failed Caused by: Network request failed Caused by: request or response body error: operation timed out (2s) Caused by: operation timed out (2s) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept to add the timeout duration to the error message. This helps users understand why the operation failed. Are you interested in such a change? In this case i would polish the code to make it ready to be reviewed and merged.
Before:
After: