Add file function to async_impl::multipart #2106
Open
+117
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaokiM03
commented
Jan 23, 2024
| @@ -104,7 +104,7 @@ impl Form { | |||
| /// | |||
| /// ```no_run | |||
| /// # fn run() -> std::io::Result<()> { | |||
| /// let files = reqwest::blocking::multipart::Form::new() | |||
| /// let form = reqwest::blocking::multipart::Form::new() | |||
There was a problem hiding this comment.
Variable names were different from the entities and have been corrected.
NaokiM03
commented
Jan 23, 2024
| } | ||
| }); | ||
|
|
||
| let url = format!("http://{}/multipart/3", server.addr()); |
There was a problem hiding this comment.
I do not know what these numbers mean.
Please let me know if there is something appropriate as I just incremented it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #646
Add file function to
async_impl::multipart::{Form, Part}.Notes
Since
From<File> for Bodywas added in #1360, I decided to use thestreamfunction that uses it internally.This comment says
the backend did not support chunked requests, butTransfer-Encoding: chunkedshould be accepted forHTTP/1.1.