support for custom DNS resolution #1653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors DNS resolution, with the goal of supporting custom DNS resolvers. It addresses #1125.
Previously, reqwest defined its own
HttpConnector
, which dispatched to a differenthyper::client::HttpConnector<R>
instance depending on an enum state. This led to excess complexity in theFuture
type associated with theService<Uri>
implementation for the connector, which can be circumvented with a trait object.This approach exchanges the enum for a trait object, which introduces a dynamic dispatch, but eliminates the enum match inside
HttpConnector
.One annoyance is that trait objects can't make use of associated types, so the return type of the
resolve
function on the trait needs to be explicitly defined. Let me know what you think - happy to make changes.